Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: flakey CI #2827

Closed
rootulp opened this issue Nov 8, 2023 · 2 comments
Closed

EPIC: flakey CI #2827

rootulp opened this issue Nov 8, 2023 · 2 comments
Assignees
@rootulp
Labels
CI item that directly relates to or modify the CI epic item groups other items for easier tracking

Comments

@rootulp
Copy link
Collaborator

rootulp commented Nov 8, 2023 •
edited
Loading

Context

Tests on celestia-app (main and v1.x) have been sporadically failing recently. Anecdotally the flakes increased in frequency in the past ~4 weeks but we prioritized last minute mainnet critical work instead of fixing all the flakes.

Proposal

The goal is for CI on celestia-app to always be green. If CI fails, it should indicate an issue in the PR and not a random test failure unrelated to the PR.

Fix all the issues labeled with flake. This may involve refactoring tests that use a testnode (a full CometBFT node) with a test app.
@rootulp rootulp added the epic item groups other items for easier tracking label Nov 8, 2023
@rootulp rootulp self-assigned this Nov 8, 2023
@evan-forbes evan-forbes added the CI item that directly relates to or modify the CI label Nov 8, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 30, 2023

#2834 merged 2 days ago and main hasn't had any flakes in the last 2 days. This doesn't rule out the possibility of future flakes so I'll keep this epic open and close the individual flake issues.

@rootulp
Copy link
Collaborator Author

rootulp commented Jan 9, 2024

Closing this epic b/c main is much less flakey. Will create new issues if we encounter new flakes.

@rootulp rootulp closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
CI item that directly relates to or modify the CI epic item groups other items for easier tracking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes