Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Make command for make test-e2e-release and run via CI #2862

Open
rootulp opened this issue Nov 20, 2023 · 4 comments
Open

Add Make command for make test-e2e-release and run via CI #2862

rootulp opened this issue Nov 20, 2023 · 4 comments
Labels
CI item that directly relates to or modify the CI testing items that are strictly related to adding or extending test coverage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Nov 20, 2023

Context

There exists a make test-e2e command that runs end-to-end tests via Knuu.

celestia-app/Makefile

Lines 119 to 123 in 1eb203c

## test-e2e: Run end to end tests via knuu. This command requires a kube/config file to configure kubernetes.
test-e2e:
@echo "--> Running end to end tests"
@KNUU_NAMESPACE=test KNUU_TIMEOUT=20m E2E_LATEST_VERSION=$(shell git rev-parse --short main) E2E_VERSIONS="$(ALL_VERSIONS)" E2E=true go test ./test/e2e/... -timeout 20m -v
.PHONY: test-e2e

This command is run via the nightly GH workflow.

Proposal

Add a new Make command (ex. make test-e2e-release) that runs the end-to-end tests via Knuu with the latest release candidate / release. Add a GH workflow that runs this workflow on new release candidates / releases. Note: the environment variables that are provided to the end-to-end test need to be modified to use the latest tagged release.

@rootulp rootulp added testing items that are strictly related to adding or extending test coverage CI item that directly relates to or modify the CI labels Nov 20, 2023
@anhductn2001
Copy link

Hey, can I take it?

@rootulp
Copy link
Collaborator Author

rootulp commented Dec 19, 2023

Hey @anhductn2001 , thanks for your interest! This task involves running tests with Knuu and a Kubernetes config so I think it may be difficult for an external contributor to work on.

@anhductn2001
Copy link

I understand this issue involves running tests with Knuu and a Kubernetes. I think I can handle it if I get your help so we can resolve the issues as quickly as possible. Pls let me know if there's anything I can help with.

@rootulp
Copy link
Collaborator Author

rootulp commented Dec 20, 2023

I can provide limited support but I can't provide a kubeconfig with access to Cloud Kubernetes resources so you may need your own environment for deploying Kubernetes containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI item that directly relates to or modify the CI testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

No branches or pull requests

2 participants