Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoReleaser "running against a shallow clone" #2896

Closed
rootulp opened this issue Dec 4, 2023 · 1 comment · Fixed by #2917
Closed

GoReleaser "running against a shallow clone" #2896

rootulp opened this issue Dec 4, 2023 · 1 comment · Fixed by #2917
Assignees
@rootulp
Labels
CI item that directly relates to or modify the CI

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 4, 2023 •
edited
Loading

Context

    • running against a shallow clone - check your CI documentation at https://goreleaser.com/ci

https://github.com/celestiaorg/celestia-app/actions/runs/7091353330/job/19300606228#step:6:71

Proposal

I think we can resolve by doing

      - uses: actions/checkout@v3
        with:
          fetch-depth: 0

Ref: https://goreleaser.com/ci/actions/#workflow

or by doing

      - run: git fetch --unshallow

Ref: https://github.com/goreleaser/goreleaser-cross-example/blob/c45dc32486e1532f330702104e2fd527891b44b9/.github/workflows/release.yaml#L14

Note: I don't expect this to fix the issue we just encountered on v1.5.0 where prebuilt binaries weren't attached b/c the existing tag v1.5.0-rc0. I just noticed this while investigating that issue.
@rootulp rootulp added the CI item that directly relates to or modify the CI label Dec 4, 2023
@rootulp rootulp self-assigned this Dec 4, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 4, 2023

Testing fetch-depth: 0 in https://github.com/rootulp/celestia-app/actions/runs/7092309648

@rootulp rootulp mentioned this issue Dec 8, 2023
Merged
rootulp added a commit that referenced this issue Dec 9, 2023
@rootulp
ci(goreleaser): set fetch-depth to 0 (#2917)
74b3404 
Closes #2896

## Testing
Before:
https://github.com/celestiaorg/celestia-app/actions/runs/7091353330/job/19300606228#step:6:71
After:
https://github.com/rootulp/celestia-app/actions/runs/7146296002/job/19463697449#step:6:68
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
ci(goreleaser): set fetch-depth to 0 (#2917)
45d4ae5 
Closes celestiaorg/celestia-app#2896

## Testing
Before:
https://github.com/celestiaorg/celestia-app/actions/runs/7091353330/job/19300606228#step:6:71
After:
https://github.com/rootulp/celestia-app/actions/runs/7146296002/job/19463697449#step:6:68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
CI item that directly relates to or modify the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(goreleaser): set fetch-depth to 0 rootulp/celestia-app
1 participant
@rootulp