Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider kebab-casing PayForBlobs in the CLI #2901

Closed
rootulp opened this issue Dec 5, 2023 · 1 comment · Fixed by #2989
Closed

Consider kebab-casing PayForBlobs in the CLI #2901

rootulp opened this issue Dec 5, 2023 · 1 comment · Fixed by #2989
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 5, 2023

Context

Originally posted by @cmwaters in #2856 (comment)

Problem

All commands in the celestia-app CLI use kebab-casing. I.e. celestia-appd tx ibc-transfer.

Proposal

Consider the breaking change of renaming PayForBlobs / PayForBlob to pay-for-blob
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 8, 2024

We could do this in a non-breaking way if we retain the PascalCase names as aliases. In other words, these would all be valid and for the same command:

celestia-appd tx blob pay-for-blobs
celestia-appd tx blob pay-for-blob
celestia-appd tx blob PayForBlobs
celestia-appd tx blob PayForBlob

@rootulp rootulp removed the breaking label Jan 8, 2024
@rootulp rootulp mentioned this issue Jan 8, 2024
Merged
@rootulp rootulp self-assigned this Jan 8, 2024
rootulp added a commit that referenced this issue Jan 8, 2024
@rootulp
feat: kebab-case pay-for-blob command (#2989)
d500540 
Closes #2901

## Testing

The previous commands still work b/c they are aliases:

```
$ ./build/celestia-appd tx blob pay-for-blob
Error: pay-for-blob requires two arguments: namespaceID and blob
$ ./build/celestia-appd tx blob pay-for-blobs
Error: pay-for-blob requires two arguments: namespaceID and blob
$ ./build/celestia-appd tx blob PayForBlob
Error: pay-for-blob requires two arguments: namespaceID and blob
$ ./build/celestia-appd tx blob PayForBlobs
Error: pay-for-blob requires two arguments: namespaceID and blob
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: kebab-case pay-for-blob command rootulp/celestia-app
1 participant
@rootulp