Consider kebab-casing PayForBlobs in the CLI
#2901
Assignees
Comments
|
We could do this in a non-breaking way if we retain the PascalCase names as aliases. In other words, these would all be valid and for the same command: celestia-appd tx blob pay-for-blobs
celestia-appd tx blob pay-for-blob
celestia-appd tx blob PayForBlobs
celestia-appd tx blob PayForBlob |
rootulp
added a commit
that referenced
this issue
Jan 8, 2024
Closes #2901 ## Testing The previous commands still work b/c they are aliases: ``` $ ./build/celestia-appd tx blob pay-for-blob Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob pay-for-blobs Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob PayForBlob Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob PayForBlobs Error: pay-for-blob requires two arguments: namespaceID and blob ```
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this issue
Aug 1, 2024
Closes celestiaorg/celestia-app#2901 ## Testing The previous commands still work b/c they are aliases: ``` $ ./build/celestia-appd tx blob pay-for-blob Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob pay-for-blobs Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob PayForBlob Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob PayForBlobs Error: pay-for-blob requires two arguments: namespaceID and blob ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Originally posted by @cmwaters in #2856 (comment)
Problem
All commands in the celestia-app CLI use kebab-casing. I.e.
celestia-appd tx ibc-transfer.Proposal
Consider the breaking change of renaming
PayForBlobs/PayForBlobtopay-for-blobThe text was updated successfully, but these errors were encountered: