Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'instrumentation.influx_tables' expected type 'string', got unconvertible type '[]interface {}', #2994

Closed
rootulp opened this issue Jan 8, 2024 · 4 comments
Assignees
Labels
bug Something isn't working investigation item tracks efforts related to an investigation. does not always require a PR to close.

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 8, 2024

Context

I think the recent celestia-core bump introduced a regression. Ref: 23d13d4

The commit before this works fine.

Problem

$ gco 23d13d4de41631dc3c52f7d94fc214e44d03962d
Previous HEAD position was 5f224ae7 feat: add support for arabica-11 in download-genesis command (#2978)
HEAD is now at 23d13d4d chore: bump core v1.31.0-tm-v0.34.29 (#2979)
$ make build
./build/celestia-appd version%
$ ./build/celestia-appd version
Error: 2 error(s) decoding:

* 'instrumentation.influx_tables' expected type 'string', got unconvertible type '[]interface {}', value: '[mempool_tx mempool_peer_state consensus_round_state consensus_block_parts consensus_block]'
* 'instrumentation.pyroscope_profile_types' expected type 'string', got unconvertible type '[]interface {}', value: '[cpu alloc_objects inuse_objects goroutines mutex_count mutex_duration block_count block_duration]'
@rootulp rootulp added bug Something isn't working investigation item tracks efforts related to an investigation. does not always require a PR to close. labels Jan 8, 2024
@rootulp rootulp self-assigned this Jan 8, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 8, 2024

Resolved by modifying my ~/.celestia-app/config/config.toml to have long strings instead of slices for these two parameters:

influx_tables = "mempool_tx,mempool_peer_state,consensus_round_state,consensus_block_parts,consensus_block"

pyroscope_profile_types = "cpu,alloc_objects,inuse_objects,goroutines,mutex_count,mutex_duration,block_count,block_duration"

@rootulp
Copy link
Collaborator Author

rootulp commented Jan 8, 2024

This was expected behavior given celestiaorg/celestia-core#1143 is a breaking change. How can we convey to users that their config needs to be updated if they bump to celestia-app main (or eventually v2.0.0)? @evan-forbes

@rootulp
Copy link
Collaborator Author

rootulp commented Jan 8, 2024

Closing this as won't fix. For posterity if you hit this, you can wipe your config:

rm -rf ~/.celestia-app

and celestia-appd will re-generate it. If you have some local modifications that you want to keep, you can modify lines in ~/.celestia-app/config/config.toml.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
@evan-forbes
Copy link
Member

perhaps we can include a migration script to just change the existing lines and include that in the release. we definitely need to inform as broadly as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigation item tracks efforts related to an investigation. does not always require a PR to close.
Projects
None yet
Development

No branches or pull requests

2 participants