Consider moving BlockedParams to paramfilter

[rootulp]

nice, if we're going to add the tests here, then we might want to move the actually params to block here as well. super duper optional tho

Originally posted by @evan-forbes in #3007 (review)

[rootulp]

@evan-forbes is the proposal to move

celestia-app/app/app.go

Lines 733 to 746 in cd0a1cd

	// BlockedParams are params that require a hardfork to change, and cannot be changed via
	// governance.
	func (*App) BlockedParams() [][2]string {
	return [][2]string{
	// bank.SendEnabled
	{banktypes.ModuleName, string(banktypes.KeySendEnabled)},
	// staking.UnbondingTime
	{stakingtypes.ModuleName, string(stakingtypes.KeyUnbondingTime)},
	// staking.BondDenom
	{stakingtypes.ModuleName, string(stakingtypes.KeyBondDenom)},
	// consensus.validator.PubKeyTypes
	{baseapp.Paramspace, string(baseapp.ParamStoreKeyValidatorParams)},
	}
	}

from the app package to the paramfilter package? I think that's API breaking but do-able.

[evan-forbes]

yeah, I think that would close this issue. I'm still of the opinion that its super optional. I don't see that much benefit either way.

we could explore other refactors as well. in the context of versioning and migrations, there might be a small benefit to moving the module. It could also make it worse if we have to import a bunch of modules with their own go mods there just to name them

[rootulp]

kk if super optional, let's close as won't do for now. Please reopen if there's a compelling reason to do this