Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more CODEOWNERS to v1.x branch #3231

Closed
rootulp opened this issue Apr 1, 2024 · 2 comments
Closed

Add more CODEOWNERS to v1.x branch #3231

rootulp opened this issue Apr 1, 2024 · 2 comments
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Apr 1, 2024

Problem

#3219 has two approvals but can't be merged because the v1.x branch doesn't have @staheri14 or @ninabarbakadze listed as CODEOWNERS

Proposal

Add @staheri14 and @ninabarbakadze as CODEOWNERS on v1.x branch
@rootulp rootulp self-assigned this Apr 1, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Apr 1, 2024

Separately, it looks like the v1.x branch file has a CODEOWNERS file with errors

Screenshot 2024-04-01 at 1 59 08 PM

@rootulp rootulp mentioned this issue Apr 1, 2024
Merged
rootulp added a commit that referenced this issue Apr 2, 2024
@rootulp
chore: add Sanaz and Nina as codeowners (#3232)
1ada3c2 
Closes #3231
@rootulp
Copy link
Collaborator Author

rootulp commented Apr 2, 2024

Closed by #3232

@rootulp rootulp closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp