Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-18 outdated upgrade information #3309

Closed
rootulp opened this issue Apr 12, 2024 · 0 comments · Fixed by #3482
Closed

ADR-18 outdated upgrade information #3309

rootulp opened this issue Apr 12, 2024 · 0 comments · Fixed by #3482
Assignees
Labels
documentation Improvements or additions to documentation priority:low optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related

Comments

@rootulp
Copy link
Collaborator

rootulp commented Apr 12, 2024

Context

The height of the upgrades will initially be hard coded into the binary. This will consist of a mapping from chain ID to app version to a range of heights that will be loaded by the application into working memory whenever the node begins and supplied directly to the `upgrades` module which will be responsible for scheduling. The chainID is required as we expect the same binary to be used across testnets and mainnet. There are a few considerations that shape how this system will work:

Problem

We won't have a hard-coded version height. Node operators will provide the v2 upgrade height via --v2-upgrade-height. We're also not using the Cosmos SDK x/upgrade module

@rootulp rootulp added WS: V2 ✌️ lemongrass hardfork related priority:low optional label to track the relative priority of planned items documentation Improvements or additions to documentation labels Apr 12, 2024
@rootulp rootulp self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority:low optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant