Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move markdown link check to run daily and Slack message failures #3324

Open
rootulp opened this issue Apr 15, 2024 · 0 comments
Open

Move markdown link check to run daily and Slack message failures #3324

rootulp opened this issue Apr 15, 2024 · 0 comments
Labels
CI item that directly relates to or modify the CI good first issue Good for newcomers priority:low optional label to track the relative priority of planned items

Comments

@rootulp
Copy link
Collaborator

rootulp commented Apr 15, 2024

Problem

We currently have a markdown link checker that runs in CI. It's not a required check because the check can be flaky. Unfortunately, since it's not a required check, a PR can be merged that adds a broken link and then CI for all other PRs have red ❌ s when they're entirely unrelated to the broken link.

Proposal

Move the markdown link check CI workflow from running on every PR to running daily. If the daily workflow fails, send a Slack message to a new Slack room about it. Add the #core-app team to the new Slack room.

[optional] if the workflow fails, retry it 3 times before actually sending a Slack message about it to avoid false positives.

@rootulp rootulp added good first issue Good for newcomers CI item that directly relates to or modify the CI priority:low optional label to track the relative priority of planned items labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI item that directly relates to or modify the CI good first issue Good for newcomers priority:low optional label to track the relative priority of planned items
Projects
None yet
Development

No branches or pull requests

1 participant