Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Come back to versioned gas scheduler variables #3748

Closed
2 tasks
ninabarbakadze opened this issue Aug 1, 2024 · 2 comments · Fixed by #3735
Closed
2 tasks

Come back to versioned gas scheduler variables #3748

ninabarbakadze opened this issue Aug 1, 2024 · 2 comments · Fixed by #3735
Assignees
@ninabarbakadze
Labels
required issue is required to be closed before workstream can be closed WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Milestone
v3

Comments

@ninabarbakadze
Copy link
Member

Description

Come back to #3404 #3735 after versioned app module upgrades and see if we want to keep the current design.

Acceptance Criteria

  • reevaluate the current status of refactor
  • write docs for the final version
@ninabarbakadze ninabarbakadze self-assigned this Aug 1, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Aug 1, 2024
Merged
@evan-forbes
Copy link
Member

to clarify from a sync, this is also dependent upon the app multiplexer

@evan-forbes evan-forbes added WS: V3 3️⃣ item is directly relevant to the v3 hardfork and removed needs:triage labels Aug 19, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 11, 2024

Come back to #3404 #3735 after versioned app module upgrades

Clarification: multi-app doesn't change the upgrade mechanism. It refactors how the binary supports multiple state machines.

@rootulp rootulp added this to the v3 milestone Sep 12, 2024
@evan-forbes evan-forbes added nice to have item is not blocking or required. required issue is required to be closed before workstream can be closed and removed nice to have item is not blocking or required. labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
required issue is required to be closed before workstream can be closed WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

refactor!: version gas scheduler variables celestiaorg/celestia-app
3 participants
@rootulp @evan-forbes @ninabarbakadze