Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a params v3 page to the specs #3762

Closed
ninabarbakadze opened this issue Aug 7, 2024 · 1 comment · Fixed by #3735 or #3914
Closed

Add a params v3 page to the specs #3762

ninabarbakadze opened this issue Aug 7, 2024 · 1 comment · Fixed by #3735 or #3914
Assignees
Labels
needs:triage WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Milestone

Comments

@ninabarbakadze
Copy link
Member

          Overall LGTM. We'll also need to add a params v3 page to the specs and mark the params: `blob.GasPerBlobByte` and `auth.TxSizeCostPerByte` as non governance modifiable on that page. 

Ref: https://github.com/celestiaorg/celestia-app/blob/main/specs/src/specs/parameters_v2.md

Originally posted by @rootulp in #3735 (review)

@ninabarbakadze ninabarbakadze self-assigned this Aug 7, 2024
@ninabarbakadze ninabarbakadze added the WS: V3 3️⃣ item is directly relevant to the v3 hardfork label Aug 7, 2024
@rootulp rootulp added this to the v3 milestone Sep 12, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 20, 2024

The parameters v3 page isn't visible on https://celestiaorg.github.io/celestia-app/parameters.html. We need to add it to:

@rootulp rootulp reopened this Sep 20, 2024
rootulp pushed a commit that referenced this issue Sep 30, 2024
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

- Fixes #3762
- Adds ante handler v3 with updated links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
2 participants