Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document moving of constants to go-square #3770

Closed
cmwaters opened this issue Aug 9, 2024 · 3 comments
Closed

Document moving of constants to go-square #3770

cmwaters opened this issue Aug 9, 2024 · 3 comments
Assignees
@rootulp
Labels
documentation Improvements or additions to documentation WS: V3 3️⃣ item is directly relevant to the v3 hardfork

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Aug 9, 2024 

          [discussion] it looks like these constants were moved to go-square. Note to future selves, we should add a line to the v3.0.0 release notes breaking changes section that consumers who imported these constants from `appconsts` can instead get them from go-square. I think we could start a changelog file for release notes like this.

Originally posted by @rootulp in #3765 (comment)
@cmwaters
Copy link
Contributor Author

cmwaters commented Aug 9, 2024

I think more broadly it might be beneficial to introduce an UPGRADING.md page

@evan-forbes evan-forbes added documentation Improvements or additions to documentation WS: V3 3️⃣ item is directly relevant to the v3 hardfork priority:low optional label to track the relative priority of planned items and removed needs:triage priority:low optional label to track the relative priority of planned items labels Aug 9, 2024
@rootulp
Copy link
Collaborator

rootulp commented Aug 9, 2024

Yea an UPGRADING.md page works for me 👍

@rootulp rootulp self-assigned this Aug 22, 2024
@rootulp
Copy link
Collaborator

rootulp commented Aug 22, 2024

Closing in favor of #3791

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rootulp @cmwaters @evan-forbes