Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API to check for message inclusion #381

Closed
3 tasks
evan-forbes opened this issue Oct 19, 2021 · 0 comments · Fixed by #681
Closed
3 tasks

Create API to check for message inclusion #381

evan-forbes opened this issue Oct 19, 2021 · 0 comments · Fixed by #681
Labels
enhancement New feature or request

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Oct 19, 2021

Summary

Create an API to check for messages inclusion.

Details

The first step has already been done by writing code to find subtree root paths. The next step should be to create an API that allows us to easily check for message inclusion given the original data square, the position of the message in question, the size of that message, along with the commitment provided in the SignedPayForMessage.

Action Items

  • define API for checking inclusion
  • compare commitments and subtree roots the SignedPayForData and the actual data in the square given the location and message size.
  • write integration tests for subtree root code

References

depends on #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants