Instruct GoReleaser to use latest tag plumbed in via Github action #4081
Assignees
Labels
nice to have
item is not blocking or required.
Comments
rootulp
added a commit
that referenced
this issue
Dec 12, 2024
Closes #4081 ## Testing On my fork all of [these releases](https://github.com/rootulp/celestia-app/actions/workflows/ci-release.yml?query=event%3Arelease) used the correct tag and uploaded prebuilt binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
GoReleaser gets confused when there are multiple tags on the same commit (i.e.
3.0.2-mocha,3.0.2-arabica). It doesn't know which one is "latest" so it may fail to attach binaries to one release if it thinks it is running on the other release.To resolve this, we introduced a workaround to determine the most recent tag based on SemVer + Celestia testnet names. See #3977
Proposal
celestia-node just merged celestiaorg/celestia-node#3979 which seems to resolve the same issue. We should consider adopting it instead.
The text was updated successfully, but these errors were encountered: