Pass app version to all ValidateBasic methods

[evan-forbes]

Stateless verification will eventually also have to be dependent upon app version. If we had this ability now, it would trivial to add a state less check on PFBs and their size ref #4084

[rootulp]

Stateless verification will eventually also have to be dependent upon app version.

This seems contradictory because if we pass app version to ValidateBasic then those checks become stateful. The checks need to access state to get the current app version.

How do we keep the checks stateless if they need to fetch the current app version?

[evan-forbes]

This seems contradictory because if we pass app version to ValidateBasic then those checks become stateful

stateless was the wrong word, the important thing is that we need to be able to change logic that is typically included in ValidateBasic depending on the app version. The routing has to occur somewhere.

We could be in a different method that takes the app version, but I think keeping the logic with the other message validation logic makes sense.

We could also cut v2 of the proto type with identical fields just to change validate basic method and route message creation based on app version client side.

something else maybe?