Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the padding in WirePayForData transactions #432

Closed
evan-forbes opened this issue May 21, 2022 · 0 comments · Fixed by #419
Closed

Don't include the padding in WirePayForData transactions #432

evan-forbes opened this issue May 21, 2022 · 0 comments · Fixed by #419
Assignees

Comments

@evan-forbes
Copy link
Member

Currently, when paying for a message to be included on chain, we add padding to the message before sending it by default. We should remove this padding from the messages, as block producers can simply add it when they are calculating the data hash. As discussed in #431, we can still pay for padding even after we remove it from the message.

This will reduce the size of the message when passed over a p2p network, cached in a mempool, or stored in the block data base/transaction index.

When we begin actually enforcing that the message share commitments are a subtree root of the data hash, and using the non-interactive defaults #382, this will cause even more padding to be necessary, which amplifies the issues of including padding in the actual message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant