-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QGB import Any type correctly #507
Comments
Do we want a new issue for this? I couldn't find one in #301 If we do create a new issue, then we may want to include a step to delete: https://github.com/celestiaorg/celestia-app/pull/742/files#diff-63113d53e02a4e334ffa1a1ba0c308329c7acd431153571a2c02ce9268af5816R28-R32 |
Sure sounds good. want me to create the issue? or you wanna do it yourself? |
Just created #744 and added it as a Nice to have, high priority in the tracking issue. |
Thanks a lot |
Currently, in the QGB, we're defining the following query:
celestia-app/proto/qgb/query.proto
Lines 103 to 109 in adfdc85
The problem is that the protobuf generated code type expects an implementation of
Any
under thecelestia-app/codec/types
.As a simple hack, we're changing the import to use the cosmos-sdk implementation of
Any
:celestia-app/x/qgb/types/query.pb.go
Line 9 in adfdc85
However, we need to find a way to specify that dynamically so that we don't have to copy all the code from cosmos-sdk repo, or make the change manually every time we generate code.
The text was updated successfully, but these errors were encountered: