New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New share format #619

Closed

1 of 4 tasks

rootulp opened this issue Aug 16, 2022 · 1 comment

Assignees

Labels

Collaborator

rootulp commented Aug 16, 2022

Summary

We're considering changing the format of a share. See: https://celestiaorg.github.io/celestia-specs/latest/specs/data_structures.html#share

Problem Definition

// TODO

Proposal

Add the following fields to share:

share length
start bit (that's on if the share is the start of a message)
version byte

This likely needs:

An ADR in this repo
A PR to update the spec
A PR to update the all share logic in this repo

Questions:

Does this have downstream consequences in celestia-node?

For Admin Use

Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned

rootulp added the enhancement label

rootulp assigned musalbas

rootulp added this to Celestia Node

rootulp moved this to TODO in Celestia Node

Member

evan-forbes commented Aug 17, 2022

closing in favor of celestiaorg/celestia-core#839

evan-forbes closed this as completed

Repository owner moved this from TODO to Done in Celestia Node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment