-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single name for each variable that references square size #687
Comments
If we opt to use |
rootulp
added a commit
to rootulp/celestia-app
that referenced
this issue
Sep 13, 2022
This was referenced Sep 13, 2022
I found another instance in celestia-app/proto/payment/tx.proto Line 34 in 27632dd
|
This was referenced Apr 18, 2023
cmwaters
pushed a commit
to celestiaorg/go-square
that referenced
this issue
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This repo uses three names for the same thing:
origSquareSize
,squareSize
,k
. Is it safe to assume they are all interchangeable? If so, would it aid readability to standardize on one? My impression is that readers who are familiar with https://celestiaorg.github.io/celestia-specs/latest/rationale/message_block_layout.html#non-interactive-default-rules are able to inferk
==squareSize
so this may not be confusing for other readers but may be helpful for new readers who aren't as familiar with the specs.Originally posted by @rootulp in #680 (comment)
We should use a single reference to square size for the entire repo.
The text was updated successfully, but these errors were encountered: