-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of unused tests #693
Comments
|
what was this reason?
yeah! the thing that urks me is that I don't know why its passing in the first place lolol
yeah, I tried to remove flags, and it just kept giving the same error but the next flag/command |
|
resolves celestiaorg#693
Research into sims
|
* chore: remove sims resolves #693 * chore: delete sims from root Makefile
There are simulation tests that aren't testing anything, and are remnants of starport. While we certainly want equivalent tests, we will not be able to rely on the current simulation package or the testapp given that most of the application is stateless and those tools were not designed for that.
https://github.com/celestiaorg/celestia-app/blob/main/contrib/devtools/sims.mk
https://github.com/celestiaorg/celestia-app/blob/main/.github/workflows/release-sims.yml
https://github.com/celestiaorg/celestia-app/blob/main/.github/workflows/sims.yml
I'm also curious as to why these tests didn't start failing until recently
The text was updated successfully, but these errors were encountered: