Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound shares used for transactions #738

Closed
adlerjohn opened this issue Nov 25, 2020 · 6 comments
Closed

Bound shares used for transactions #738

adlerjohn opened this issue Nov 25, 2020 · 6 comments
Labels
ice-box this label is automatically applied to all issues. it is removed after starting work proposal item is not yet actionable and is suggesting a change that must first be agreed upon

Comments

@adlerjohn
Copy link
Member

adlerjohn commented Nov 25, 2020

The number of shares used for transactions, intermediate state roots, evidence, etc. should be bounded by some parameter. Otherwise, a malicious validator could create a maximum-size block filled with only transactions, and all full node would be required to fully download and process the block to compute the state.

@adlerjohn adlerjohn added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 25, 2020
@adlerjohn adlerjohn self-assigned this Nov 25, 2020
@adlerjohn
Copy link
Member Author

There is good reason to also separately bound the number of shares available to use for paying for messages, and all other requests with a reserved namespace ID: it avoids the two sharing a fee market.

@adlerjohn adlerjohn transferred this issue from celestiaorg/celestia-specs Sep 19, 2022
@adlerjohn adlerjohn added specs directly relevant to the specs and removed documentation Improvements or additions to documentation enhancement New feature or request labels Sep 19, 2022
@evan-forbes
Copy link
Member

evan-forbes commented Sep 19, 2022

This was implemented when we added a max square size, and will be turned into a configurable parameter when we do #183

@evan-forbes
Copy link
Member

evan-forbes commented Sep 29, 2022

I think I read this too quickly when closing, we still need to implement this

@evan-forbes evan-forbes moved this to TODO in Celestia Node Sep 29, 2022
@rootulp rootulp added discussion inherently unactionable issue for the sole purpose of discussion and removed specs directly relevant to the specs labels Nov 1, 2022
@rootulp
Copy link
Collaborator

rootulp commented Dec 6, 2022

it avoids the two sharing a fee market

If transactions have a different fee market then we may consider adopting a sparse share scheme for transaction shares (initially proposed in #1040). The rationale is that it isn't possible to determine exactly how many shares a PFB will occupy when using a compact share scheme. In order to meter a PFB for the number of shares they occupy, we would have to round up to the worst case number of shares. If transaction shares used a sparse share scheme, they could be metered based on the exact number of shares they occupy (similar to how blob shares are metered after #431).

Note: we could still have a separate fee market and meter transactions based on number of bytes rather than number of shares.

@adlerjohn
Copy link
Member Author

Hmmm. Fee markets don't necessarily have to be played out entirely in-protocol. Ultimately, it's up to the block producers how they calculate priority.

@evan-forbes
Copy link
Member

evan-forbes commented Feb 21, 2024

This can be closed now that the square is deterministic, which prevents filling the square with empty or nonsensical data, however there could still be a restriction put on how many txs could be included

@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Feb 21, 2024
@evan-forbes evan-forbes added the needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk label Feb 21, 2024
@evan-forbes evan-forbes reopened this Feb 21, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Celestia Node Feb 21, 2024
@evan-forbes evan-forbes added proposal item is not yet actionable and is suggesting a change that must first be agreed upon and removed discussion inherently unactionable issue for the sole purpose of discussion needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk labels Mar 11, 2024
@evan-forbes evan-forbes added the ice-box this label is automatically applied to all issues. it is removed after starting work label Mar 11, 2024
@celestiaorg celestiaorg locked and limited conversation to collaborators Mar 11, 2024
@evan-forbes evan-forbes converted this issue into discussion #3169 Mar 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Celestia Node Mar 11, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
ice-box this label is automatically applied to all issues. it is removed after starting work proposal item is not yet actionable and is suggesting a change that must first be agreed upon
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants