Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGB use existing testing infrastructure #745

Closed
Tracked by #301
rach-id opened this issue Sep 20, 2022 · 1 comment
Closed
Tracked by #301

QGB use existing testing infrastructure #745

rach-id opened this issue Sep 20, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented Sep 20, 2022

We should use the existing

celestia-app/testutil/test_app.go

Line 71 in e18de88

func SetupTestAppWithGenesisValSet(t *testing.T) *app.App {
for the QGB tests instead of:

func SetupTestChain(t *testing.T, weights []uint64) (TestInput, sdk.Context) {

Originally posted by @evan-forbes in #742 (comment)
@rach-id rach-id added C: QGB enhancement New feature or request labels Sep 20, 2022
@rach-id rach-id moved this to TODO in Celestia Node Sep 20, 2022
This was referenced Sep 20, 2022
Closed
Merged
@rach-id rach-id added the good first issue Good for newcomers label Oct 4, 2022
@rach-id rach-id mentioned this issue Oct 17, 2022
Closed
@rach-id
Copy link
Member Author

rach-id commented Feb 21, 2024

no longer needed as we're switching to BlobstreamX

@rach-id rach-id closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id