Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate consts for MaxSquareSize and MinSquareSize #895

Closed
rahulghangas opened this issue Oct 20, 2022 · 0 comments
Closed

Deprecate consts for MaxSquareSize and MinSquareSize #895

rahulghangas opened this issue Oct 20, 2022 · 0 comments
Assignees
@rahulghangas
Labels
enhancement New feature or request

Comments

@rahulghangas
Copy link
Contributor

rahulghangas commented Oct 20, 2022 •
edited
Loading

Summary

Deprecate global constants for MinSquareSize and MaxSquareSize in favour of them being params to the payment module, which is then configurable/changeable via governance proposals

Supersedes #183 after #893 is merged

Problem Definition

MinSquareSize and MaxSquareSize are not configurable

Proposal

Deprecate constants and make them parameters to the payment module
@rahulghangas rahulghangas added the enhancement New feature or request label Oct 20, 2022
@rahulghangas rahulghangas self-assigned this Oct 20, 2022
@evan-forbes evan-forbes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulghangas rahulghangas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahulghangas @evan-forbes