-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move default values for blob params to appconsts module #993
Comments
Naive question but why do we want to define these default parameters in the I assume the end-goal is that the defaults are only used to set the initial value of the parameter in the blob module and after that the parameters are subject to modification through governance. The value that should be used throughout the application is therefore the parameter in the blob module not the default in |
This was done because I wanted to do the changes incrementally (since it's going to break app in a few different places). PR resolving #1032 will replace all usages of default values to |
I don't follow why this issue is desirable as an incremental step. If the Since the initial value (i.e the default) is an implementation detail of the blob module, it can be un-exported. Only the current |
I'm fine with moving these, but I also definitely see the reasoning behind keeping them in the blob module since that's where we're planning on keeping these params |
Moves default values for min/max swaure size and gas per blob byte to appconsts module. Renames `MinSquareSize` and `MaxSquareSize` in appconsts module to `DefaultMinSquareSize` and `DefaultMaxSquareSize` - [x] closes #993 Co-authored-by: Rootul P <[email protected]>
Summary
Default values for blob params are currently hardcoded and should be moved to
appconsts
moduleThe text was updated successfully, but these errors were encountered: