From 296c162f7b0e2ebd46b498423a8d9dfa5a6b24c8 Mon Sep 17 00:00:00 2001 From: crStiv Date: Thu, 12 Dec 2024 23:22:56 +0100 Subject: [PATCH 1/5] typos --- app/app.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/app.go b/app/app.go index eadd034ea1..8f15e0ea37 100644 --- a/app/app.go +++ b/app/app.go @@ -180,7 +180,7 @@ type App struct { // // NOTE: upgradeHeightV2 refers specifically to the height that a node will // upgrade from v1 to v2. It will be deprecated in v3 in place for a dynamically -// signalling scheme +//signaling scheme func New( logger log.Logger, db dbm.DB, @@ -258,7 +258,7 @@ func New( ) app.FeeGrantKeeper = feegrantkeeper.NewKeeper(appCodec, keys[feegrant.StoreKey], app.AccountKeeper) - // The upgrade keeper is intialised solely for the ibc keeper which depends on it to know what the next validator hash is for after the + // The upgrade keeper is initialised solely for the ibc keeper which depends on it to know what the next validator hash is for after the // upgrade. This keeper is not used for the actual upgrades but merely for compatibility reasons. Ideally IBC has their own upgrade module // for performing IBC based upgrades. Note, as we use rolling upgrades, IBC technically never needs this functionality. app.UpgradeKeeper = upgradekeeper.NewKeeper(nil, keys[upgradetypes.StoreKey], appCodec, "", app.BaseApp, authtypes.NewModuleAddress(govtypes.ModuleName).String()) @@ -472,7 +472,7 @@ func (app *App) EndBlocker(ctx sdk.Context, req abci.RequestEndBlock) abci.Respo panic(err) } } - // from v2 to v3 and onwards we use a signalling mechanism + // from v2 to v3 and onwards we use a signaling mechanism } else if shouldUpgrade, newVersion := app.SignalKeeper.ShouldUpgrade(ctx); shouldUpgrade { // Version changes must be increasing. Downgrades are not permitted if newVersion > currentVersion { From b76ee4f8de52d18d2b0cb8a91b883bb9f7ca958e Mon Sep 17 00:00:00 2001 From: crStiv Date: Thu, 12 Dec 2024 23:24:09 +0100 Subject: [PATCH 2/5] article redundancy --- app/app_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/app_test.go b/app/app_test.go index ae1c6089f5..af978b5f3b 100644 --- a/app/app_test.go +++ b/app/app_test.go @@ -44,7 +44,7 @@ func TestNew(t *testing.T) { }) t.Run("should have set StakingKeeper hooks", func(t *testing.T) { // StakingKeeper doesn't expose a GetHooks method so this checks if - // hooks have been set by verifying the a subsequent call to SetHooks + // hooks have been set by verifying the subsequent call to SetHooks // will panic. assert.Panics(t, func() { got.StakingKeeper.SetHooks(nil) }) }) From d3098d7dc50d81103b5219a1153fa8f418b53742 Mon Sep 17 00:00:00 2001 From: crStiv Date: Thu, 12 Dec 2024 23:35:17 +0100 Subject: [PATCH 3/5] typo --- docker/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/Dockerfile b/docker/Dockerfile index 0e3c4bf51d..d2e9e52a2c 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -8,7 +8,7 @@ ARG BUILDER_IMAGE=docker.io/golang:1.23.1-alpine3.20 ARG RUNTIME_IMAGE=docker.io/alpine:3.19 ARG TARGETOS ARG TARGETARCH -# Use build args to override the maxuimum square size of the docker image i.e. +# Use build args to override the maximum square size of the docker image i.e. # docker build --build-arg MAX_SQUARE_SIZE=64 -t celestia-app:latest . ARG MAX_SQUARE_SIZE # Use build args to override the upgrade height delay of the docker image i.e. From 87233526c09c091ba848b732b7848eab32647b6e Mon Sep 17 00:00:00 2001 From: crStiv Date: Thu, 12 Dec 2024 23:37:12 +0100 Subject: [PATCH 4/5] typo --- app/ante/tx_size_gas.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/ante/tx_size_gas.go b/app/ante/tx_size_gas.go index 356f6f2646..9ddd40aa37 100644 --- a/app/ante/tx_size_gas.go +++ b/app/ante/tx_size_gas.go @@ -35,7 +35,7 @@ func init() { // ConsumeTxSizeGasDecorator will take in parameters and consume gas proportional // to the size of tx before calling next AnteHandler. Note, the gas costs will be -// slightly over estimated due to the fact that any given signing account may need +// slightly overestimated due to the fact that any given signing account may need // to be retrieved from state. // // CONTRACT: If simulate=true, then signatures must either be completely filled From c377773b6118e65935cbdb3a0396204136854d2c Mon Sep 17 00:00:00 2001 From: crStiv Date: Thu, 12 Dec 2024 23:40:43 +0100 Subject: [PATCH 5/5] accidentally changed this changed "signalling" to "signaling" but accidentally didn't use "space" between the slash and "signaling" --- app/app.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/app.go b/app/app.go index 8f15e0ea37..125ae8b578 100644 --- a/app/app.go +++ b/app/app.go @@ -180,7 +180,7 @@ type App struct { // // NOTE: upgradeHeightV2 refers specifically to the height that a node will // upgrade from v1 to v2. It will be deprecated in v3 in place for a dynamically -//signaling scheme +// signaling scheme func New( logger log.Logger, db dbm.DB,