Don't assume that all transaction reaped from the mempool will be accepted by the application #1007
Labels
Comments
evan-forbes
changed the title
Closed
5 tasks
5 tasks
|
first before we move forward with a solution to this issue we should gather more data on roughly how large of a problem this is. We first need a metric determining how efficient this process is |
|
We could track as a metric how many transactions are rejected by the application |
3 tasks
cmwaters
added a commit
that referenced
this issue
Jul 31, 2024
## Description Add counter to the block executor metrics : - RejectedTransactions Resolves #1241 Unblocks #1007 #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: 0xEclair <[email protected]> Co-authored-by: Callum Waters <[email protected]>
cmwaters
added a commit
that referenced
this issue
Jul 31, 2024
Add counter to the block executor metrics : - RejectedTransactions Resolves #1241 Unblocks #1007 - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: 0xEclair <[email protected]> Co-authored-by: Callum Waters <[email protected]>
evan-forbes
pushed a commit
that referenced
this issue
Jul 31, 2024
Add counter to the block executor metrics : - RejectedTransactions Resolves #1241 Unblocks #1007 - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: 0xEclair <[email protected]> Co-authored-by: Callum Waters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, tendermint will reap transactions on the mempool based on the
MaxBytesconsensus param because it assumes that all the transactions that are reaped will make it in the block. Since this assumption is not true, we should instead reap more thanMaxBytesand rely on the application to create proposals that are small enough.edit: per discussion below this issue is blocked by #1241The text was updated successfully, but these errors were encountered: