Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that the block data should no longer be used #1015

Open
evan-forbes opened this issue May 25, 2023 · 0 comments
Open

Document that the block data should no longer be used #1015

evan-forbes opened this issue May 25, 2023 · 0 comments
Labels
C:documentation Improvements or additions to documentation

Comments

@evan-forbes
Copy link
Member

Now that square construction is deterministic, we are no longer need the SquareSize field in the block data, and it should not be used in square construction. The only reason we are still keeping it is as a cache, so that tendermint doesn't have to ask the application to calculate it each time it creates a data commitment for the qgb.

We should document this a bit more in a few places since it is likely not intuitive.

@evan-forbes evan-forbes added the C:documentation Improvements or additions to documentation label May 25, 2023
cmwaters pushed a commit that referenced this issue Sep 20, 2023
Closes #666

This PR adds double quotes to `path` param of `/abci_query` endpoint.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit f6f13b1)

Co-authored-by: Steven Ferrer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant