Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Blob, BlobTx, and NMTProof, to their own module #1100

Open
evan-forbes opened this issue Sep 27, 2023 · 0 comments
Open

Move Blob, BlobTx, and NMTProof, to their own module #1100

evan-forbes opened this issue Sep 27, 2023 · 0 comments
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Sep 27, 2023

We have types such as Blob and BlobTx that were originally defined in here. We might even be able to eventually completely remove them from this repo now that we have removed the Blob type from the block data. Before doing that, we should move them to their own module. Ideally we also move some core types and functions, such as types.Tx and crypto/merkle to their own module as well, but I'm still unsure of the repercussions of that.

This will allow us to create modules here that are importable by other projects that can't import two forks of tendermint without delving into dependency hell. This will be useful specifically for rollkit, who needs to import the shares package. It would also allow for us to modularize the blob and user packages, which would allow for teams to import and sign PFBs without needing to replace their own version of tendermint or the sdk with our forks (note that this would be a bit of a foot gun, since if the core types used by our forks ever deviate from whatever version is being used there will be weird bugs).

blocking celestiaorg/celestia-app#2570

@evan-forbes evan-forbes self-assigned this Sep 27, 2023
@rootulp rootulp added this to the Post-mainnet milestone Oct 9, 2023
@evan-forbes evan-forbes removed their assignment Nov 13, 2023
@evan-forbes evan-forbes modified the milestones: Post-mainnet, v2 Nov 13, 2023
@cmwaters cmwaters self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants