Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic queue for block prop #1520

Open
evan-forbes opened this issue Oct 18, 2024 · 1 comment
Open

Use dynamic queue for block prop #1520

evan-forbes opened this issue Oct 18, 2024 · 1 comment
Labels
proposal ideas that are not planned WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Oct 18, 2024

one simple change we do for all forms of block prop (including mempools), is to utilize a dynamic queue.

For the existing consensus reactor, we queue block parts to be send for each peer every MaxGossipDelay. It's very possible to receive a block part from a peer that we have queued but have yet to pass through to the tcp buffer. When that's the case, it would be more optimal to not send that block part. If we had the ability to remove block parts from they queue, then nodes could do this as they receive block parts from their peers.

For mempools, the highest priority txs can be gossiped first, not unlike #1069. However, from a discussion w/ @cmwaters, we could move beyond #1069, and we can define priority differently. Instead of only basing this on gas price, we can always feed peers txs that are included in high priority VACs or compact blocks.

an example implementation was done in the big blonks testnet here https://github.com/celestiaorg/celestia-core/blob/evan/pipeline-cat-hack/mempool/cat/sorted_queue.go

@evan-forbes evan-forbes added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols needs:discussion labels Oct 18, 2024
@evan-forbes
Copy link
Member Author

we should split this issue up into two: the ability to remove things from the queue and the ability to sort. We only need the ability to remove for push based, and the ability to sort for pull based

@evan-forbes evan-forbes added the proposal ideas that are not planned label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal ideas that are not planned WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

No branches or pull requests

1 participant