Stop automatically broadcasting transactions from the rpc #1529
Labels
cat 🐈
fix
good first issue
Good for newcomers
WS: Big Blonks 🔭
Improving consensus critical gossiping protocols
Currently, CAT automatically broadcasts transactions from the rpc to all peers. There are several problems with this.
While initially it seemed like an reasonable optimization, upon closer inspection in a real network, this almost guarantees that nodes in the network end up downloading the transaction more than once. This is because nodes will often receive a
Have
msg from other peers before they download the entire tx from the sender. They they get download the transaction twice.This also stops nodes from enforcing the powerful and simple spam prevention mechanism of kicking peers that send them transactions that they didn't ask for.
While very unlikely atm, it's possible for a user to submit the same transaction to every RPC endpoint that is available, which would result in downloading a ton of redundant data, and we'd lose the benefits of using pull based gossip.
With these three things in consideration, we should stop automatically sending transactions received from the RPC
The text was updated successfully, but these errors were encountered: