Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write block data to IPFS asynchronously #204

Closed
evan-forbes opened this issue Mar 10, 2021 · 1 comment · Fixed by #271
Closed

Write block data to IPFS asynchronously #204

evan-forbes opened this issue Mar 10, 2021 · 1 comment · Fixed by #271
Labels
C:ipld Access to the IPLD merkle dag

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Mar 10, 2021 •
edited
Loading

Per a todo in #178 we should investigate the consequences of posting data asynchronously. This will likely be the case in the future, particularly when block sizes begin to increase.
@liamsi liamsi added the C:ipld Access to the IPLD merkle dag label Mar 10, 2021
@evan-forbes
Copy link
Member Author

I'm going to go ahead and tack on another related todo from the same PR. This TODO simply asks to not hard code a timeout for writing data to IPFS via PutBlock. This can be handled while writing the data asynchronously.

@evan-forbes evan-forbes mentioned this issue Mar 11, 2021
Merged
@evan-forbes evan-forbes mentioned this issue Apr 7, 2021
Merged
@evan-forbes evan-forbes mentioned this issue May 5, 2022
Closed
cmwaters added a commit that referenced this issue Mar 13, 2023
@jmalicevic @cmwaters
config v0.34: use a different source of versioning (#204)
ce0db1f 
* config: use a different source of versioning (#9486)

* Changed version generation

* Fixed comment describing the versioning

Co-authored-by: Callum Waters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:ipld Access to the IPLD merkle dag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent double writes of samples to IPFS celestiaorg/celestia-core
2 participants
@liamsi @evan-forbes