Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in missing system constants #24

Closed
liamsi opened this issue Apr 22, 2020 · 0 comments · Fixed by #83
Closed

Add in missing system constants #24

liamsi opened this issue Apr 22, 2020 · 0 comments · Fixed by #83
Labels
C:erasure-coding Component: Erasure coding P:High Priority High
Milestone
lazyledger-core 1...

Comments

@liamsi
Copy link
Member

liamsi commented Apr 22, 2020 •
edited
Loading

Add in the missing constants from the spec into lazyledger-core.
https://github.com/LazyLedger/lazyledger-specs/blob/master/specs/consensus.md#constants

Not all belong here (e.g. GENESIS_COIN_COUNT would be defined outside of LL-core in the app) but others (NAMESPACE_ID_BYTES , SHARE_SIZE , SHARE_RESERVED_BYTES) either need to be const for one chain as they will be used in the erasure coding scheme.
@liamsi liamsi added C:erasure-coding Component: Erasure coding P:High Priority High labels Apr 22, 2020
@liamsi liamsi added this to the lazyledger-core 1.0.0-alpha milestone Apr 22, 2020
@liamsi liamsi mentioned this issue Sep 10, 2020
Closed
@liamsi liamsi mentioned this issue Oct 30, 2020
Merged
6 tasks
@liamsi liamsi closed this as completed in #83 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:erasure-coding Component: Erasure coding P:High Priority High
Projects
None yet
Milestone
lazyledger-core 1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

Basic DA functionality celestiaorg/celestia-core
1 participant
@liamsi