Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adr: DAHeader and ipfs #378

Closed
liamsi opened this issue May 31, 2021 · 1 comment
Closed

adr: DAHeader and ipfs #378

liamsi opened this issue May 31, 2021 · 1 comment
Labels
C:data-availability Component: Data Availability Proofs T:adr

Comments

@liamsi
Copy link
Member

liamsi commented May 31, 2021

Summary

When we started thinking about howto implement the DAS light client, we observed that it could make sense to make the DAHeader downloadable via IPFS too. Especially in an non-RPC, fully p2p light client context this could makes sense (ref: #86).

We should write an ADR that explains how the implementation of this would like in details but also explains trade-offs to alternative approaches (e.g. the DAHeader could also propagate in the same way as headers).

This is a followup issue to #307
@liamsi liamsi added C:data-availability Component: Data Availability Proofs T:adr labels May 31, 2021
@liamsi liamsi mentioned this issue May 31, 2021
Closed
5 tasks
@Wondertan Wondertan mentioned this issue May 31, 2021
Closed
5 tasks
@liamsi
Copy link
Member Author

liamsi commented Aug 16, 2021

The code this ADR is about should either be moved into a separate repo or simply be moved into https://github.com/celestiaorg/celestia-node. Hence, closing.

ref: celestiaorg/celestia-node#1

@liamsi liamsi closed this as completed Aug 16, 2021
@Wondertan Wondertan mentioned this issue Aug 16, 2021
Closed
2 tasks
cmwaters pushed a commit that referenced this issue Mar 13, 2023
@mergify @thanethomson
ci: Remove Buf tokens from workflow (backport #378) (#380)
ab529de 
* ci: Remove Buf tokens from workflow (#378)

* ci: Remove Buf tokens from workflow

Signed-off-by: Thane Thomson <[email protected]>

* Format proto folder readme to trigger workflow

Signed-off-by: Thane Thomson <[email protected]>

---------

Signed-off-by: Thane Thomson <[email protected]>
(cherry picked from commit 126f190)

# Conflicts:
#	proto/README.md

* Fix conflict in proto readme

Signed-off-by: Thane Thomson <[email protected]>

---------

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:data-availability Component: Data Availability Proofs T:adr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liamsi