Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange available data in shares according to spec #38

Closed
liamsi opened this issue Jun 24, 2020 · 2 comments
Closed

Arrange available data in shares according to spec #38

liamsi opened this issue Jun 24, 2020 · 2 comments
Labels
C:erasure-coding Component: Erasure coding P:High Priority High

Comments

@liamsi
Copy link
Member

liamsi commented Jun 24, 2020

Before implementing the erasure coding of the data itself (see #23), we need to arrange the data into a square matrix to do so. A naive approach would be to split the data in same sized shares and order that into a matrix. It would be better to implement this directly by following the message layout of the spec s.t. the implementation evolves closer to the spec and potentially inform give feedback for the spec itself.

Specification: https://github.com/lazyledger/lazyledger-specs/blob/master/specs/data_structures.md#arranging-available-data-into-shares
Rationale document: https://github.com/lazyledger/lazyledger-specs/blob/master/rationale/message_block_layout.md

ref: celestiaorg/celestia-specs#69

@liamsi liamsi added C:erasure-coding Component: Erasure coding P:High Priority High labels Jun 24, 2020
@liamsi liamsi added this to the lazyledger-core 1.0.0-alpha milestone Jun 24, 2020
@musalbas
Copy link
Member

The rsmt2d library expects a flattened slice of shares, as the library arranges it into a square for you.

In order to enforce a particular layout, one could arrange it as wanted before flatenning it and passing it to the library. Either way the message layout specified in the spec isn't consensus critical.

@liamsi liamsi self-assigned this Jun 24, 2020
@liamsi liamsi changed the title Arrange available data in shares for rsmt2d Arrange available data in shares according to spec Feb 16, 2021
@liamsi liamsi removed their assignment Mar 7, 2021
@liamsi
Copy link
Member Author

liamsi commented Mar 20, 2021

closing in favour of #234 which has more details and hence is more actionable.

@liamsi liamsi closed this as completed Mar 20, 2021
cmwaters pushed a commit that referenced this issue Mar 13, 2023
Bumps [rtCamp/action-slack-notify](https://github.com/rtCamp/action-slack-notify) from 2.1.3 to 2.2.0.
- [Release notes](https://github.com/rtCamp/action-slack-notify/releases)
- [Commits](rtCamp/action-slack-notify@f565a63...12e36fc)

---
updated-dependencies:
- dependency-name: rtCamp/action-slack-notify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:erasure-coding Component: Erasure coding P:High Priority High
Projects
None yet
Development

No branches or pull requests

2 participants