Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from upstream #492

Closed
Tracked by #114
evan-forbes opened this issue Aug 13, 2021 · 5 comments
Closed
Tracked by #114

Upgrade from upstream #492

evan-forbes opened this issue Aug 13, 2021 · 5 comments

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Aug 13, 2021

We will have to update our fork of the latest version of tendermint if we want to take advantage of security patches and upcoming features such as ABCI++.

Unfortunately, due to significant refactoring in tendermint since we forked, updating will be a little bit more complicated than strictly rebasing our changes onto the latest master branch.

This should likely be done after as much code as possible has been moved to the celestia-node repo, and we should also document each of the changes #482.

As a bonus, we should also think about streamlining the process of merging future updates.

@evan-forbes evan-forbes mentioned this issue Aug 13, 2021
31 tasks
@evan-forbes evan-forbes changed the title upgrade from upstream (after minimizing changes in core): tendermint, Cosmos-SDK, app Upgrade from upstream Aug 13, 2021
@tac0turtle tac0turtle self-assigned this Aug 16, 2021
@tac0turtle
Copy link
Collaborator

assigning to myself. I am working on this.

I am just about done with the merge conflicts, down to 60 out of 300. Then will fix tests and compare with changes here and in Tendermint. I should have a PR up later today.

@evan-forbes
Copy link
Member Author

evan-forbes commented Aug 25, 2021

Update: we decided to wait a bit and revert quite a few changes. Most of those change have since been reverted, see #436 #509 #518 and #514, and it should be significantly easier to upgrade to the latest version of tendermint. We also would like to do this sooner rather than later, as everything else we're working on depends on celestia-core to some extent.

@marbar3778 do you think you'll have time to start this again? If not, I'm happy to start rebasing and then maybe you can help me debug after? Thanks!

@tac0turtle
Copy link
Collaborator

tac0turtle commented Aug 26, 2021

@marbar3778 do you think you'll have time to start this again? If not, I'm happy to start rebasing and then maybe you can help me debug after? Thanks!

Yea i can restart it later today. Ill try to get a PR up asap

@evan-forbes
Copy link
Member Author

Thanks @marbar3778! you're the best

@evan-forbes
Copy link
Member Author

closed by the merging of #534

evan-forbes pushed a commit that referenced this issue Jun 9, 2023
* Reorganize existing guides (#492)

* Moves all guides to a guids folder

* Moves the actual intro to the README.md of the intro folder

* Add guides to the guide README.md

* Fixing links in docs/README.md

(cherry picked from commit fa98b5e)

# Conflicts:
#	docs/README.md
#	docs/guides/java.md
#	docs/guides/kotlin.md
#	docs/introduction/README.md
#	docs/introduction/what-is-cometbft.md

* solving conflicts

* Add guides to the guide README.md

---------

Co-authored-by: Lasaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants