Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the DataAvailabilityHeader from the Proposal #517

Closed
1 task
evan-forbes opened this issue Aug 25, 2021 · 0 comments · Fixed by #518
Closed
1 task

Remove the DataAvailabilityHeader from the Proposal #517

evan-forbes opened this issue Aug 25, 2021 · 0 comments · Fixed by #518

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Aug 25, 2021

Summary

We no longer need the DataAvailaibiltyHeader in the Proposal, so we should remove it.

Details

Originally introduced in #248, the DAH was added to the Proposal so that validators could sample and verify fraud proofs during consensus. That is no longer necessary, so it should be removed. Removal might be a tad cumbersome, as we've made quite a few changes since #248, so if doing a simple git revert causes a lot a issues, we can remove it manually.

Since the DAH will no longer be in the proposal or the block #512 , we should keep the DAH in BlockMeta as to still save it, or save it separately.

Action Items

  • Remove the DataAvailabilityHeader from the Proposal

References

comment that spawned the discussion.
tracked in #491 and #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant