-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tendermint/issue#2639 (preprocessing of blocks) #59
Comments
I'm happy to complete my PR and submit it to lazyledger. Will try to do this in the coming days. |
I would propose before making this change the If there is agreement with this, I can begin to doing needed changes for |
I have a branch that is 80% done for finalize block. I can complete it in the coming days and open it against ll core |
* ci: Update Docker build workflows (#59) Signed-off-by: Thane Thomson <[email protected]> Signed-off-by: Thane Thomson <[email protected]> (cherry picked from commit ddd0117) # Conflicts: # .github/workflows/tendermint-docker.yml * Resolve conflicts Signed-off-by: Thane Thomson <[email protected]> Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Thane Thomson <[email protected]>
It would allow us to more cleanly write the intermediate state roots from the (abci) app into the Block.Data.
Also, clarify if we can also use this mechanism to write the (LL applications') messages into the block data (otherwise we'd have potentially large blobs in the mem pool for no reason).
ref: https://github.com/tendermint/tendermint/issues/2639 (tendermint issue)
ref: https://github.com/marbar3778/tendermint/pull/17 (a first stab on an implementation by @marbar3778)
The text was updated successfully, but these errors were encountered: