Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support malleated transactions in the event system #590

Closed
evan-forbes opened this issue Dec 3, 2021 · 1 comment · Fixed by #607
Closed

Support malleated transactions in the event system #590

evan-forbes opened this issue Dec 3, 2021 · 1 comment · Fixed by #607
Assignees

Comments

@evan-forbes
Copy link
Member

Summary

When submitting a WirePayForMessage transaction, celestia-core fails to notify a user that the transaction was included in a block.

Details

Tendermint makes the assumption that a submitted transaction is identical to the transaction that is included in a block. This is not the case for WirePayForMessage, which needs to be malleated into a PayForMessage before being committed to.

This breaks the event system, as well as the mempool #581, which uses hashes to identify transactions. source

Action Items

Either:

  • fix here using a similar solution as #582
  • fix here using a better solution than #582
  • fix in celestia-node

References

hacky solution we used in the mempool for devnet #582 #583
tracking issue #152
blocking dalc #17

@evan-forbes
Copy link
Member Author

closed with #607

@evan-forbes evan-forbes moved this to Done in Celestia Node Jan 10, 2022
@evan-forbes evan-forbes self-assigned this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant