Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ABCI++ branch with celestia specific changes #623

Closed
evan-forbes opened this issue Jan 31, 2022 · 2 comments
Closed

Create ABCI++ branch with celestia specific changes #623

evan-forbes opened this issue Jan 31, 2022 · 2 comments
Assignees
Labels
C:abci The connection between ll-core and the (abci) app

Comments

@evan-forbes
Copy link
Member

We should create a release branch that incorporates all of the necessary celestia specific changes with all of the changes made so far with upstream's ABCI++ branch

@evan-forbes evan-forbes added the C:abci The connection between ll-core and the (abci) app label Jan 31, 2022
@evan-forbes evan-forbes self-assigned this Jan 31, 2022
@evan-forbes evan-forbes moved this to TODO in Celestia Node Jan 31, 2022
@evan-forbes evan-forbes moved this from TODO to In Progress in Celestia Node Feb 7, 2022
@evan-forbes evan-forbes moved this from In Progress to In Review in Celestia Node Feb 21, 2022
@liamsi
Copy link
Member

liamsi commented Apr 14, 2022

What is the status/purpose of this? If we want to diff between this and upstream, we can do so from our main branch and look at the abci++ changes manually?

@adlerjohn adlerjohn moved this from In Review to TODO in Celestia Node Apr 14, 2022
@evan-forbes
Copy link
Member Author

evan-forbes commented Apr 17, 2022

I think was meant to be closed by #631

Closes #623

but the format was wrong so the github hook didn't pick up on it. Any future changes related to ABCI++ should be incorporated via cherry-picking changes from an old celestia release branch onto a branch based on some stable/release branch of tendermint

Repository owner moved this from TODO to Done in Celestia Node Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:abci The connection between ll-core and the (abci) app
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants