Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DA header from proposal #866

Closed
adlerjohn opened this issue Jul 6, 2021 · 1 comment
Closed

Remove DA header from proposal #866

adlerjohn opened this issue Jul 6, 2021 · 1 comment

Comments

@adlerjohn
Copy link
Member

adlerjohn commented Jul 6, 2021

Pending acceptance of ADR-006, the PartSetHeader is used to gossip blocks in the consensus reactor, which means there is no need to include the DA header in the proposal since validators don't do DAS.

As per celestiaorg/celestia-specs#180 (comment), consider removing the DA header from proposal, if we use PartSetHeader to gossip blocks.

DAHeader is included in proposal: if validators don't do DAS this is not a strict requirement anymore! Only if the spec wants to very vaguely and very implicitly make assumptions around block propagation during consensus, which indeed is an implementation detail. If we want to keep the DAHeader in the Proposal, we should clarify here why DAHeader is included in the first place (previously for sampling, now for ??). Also if proposal include the DAHeader why don't Votes also include it?

@evan-forbes
Copy link
Member

completed in #518

and since this reversion puts on par with tendermint, we should simply point to the tendermint specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants