Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github workflow for go mod tidy #873

Open
rootulp opened this issue Oct 27, 2022 · 1 comment
Open

Github workflow for go mod tidy #873

rootulp opened this issue Oct 27, 2022 · 1 comment
Labels
github_actions Pull requests that update Github_actions code

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 27, 2022

Context

#871 (comment)

Problem

It is possible for a PR to be merged to this repo where go mod tidy hasn't been run. This is problematic because when developers pull latest v0.34.x-celestia and make a change, running go mod tidy may modify imports in go.mod that are unrelated to their change.

Proposal

Add a Github workflow that fails if go mod tidy hasn't been run on the PR
@rootulp rootulp added the github_actions Pull requests that update Github_actions code label Oct 27, 2022
@rootulp rootulp mentioned this issue Oct 27, 2022
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 14, 2022

Can be used for inspiration: https://github.com/celestiaorg/utils/blob/24df3ac03c2a5410819a00296181b5cc5ddab2bc/.github/workflows/ci_release.yml#L49-L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp