Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer int64 over uint64 for block heights in DataComittment #900

Open
rootulp opened this issue Dec 5, 2022 · 0 comments
Open

Prefer int64 over uint64 for block heights in DataComittment #900

rootulp opened this issue Dec 5, 2022 · 0 comments
Labels
blobstream quantum gravity bridge T:enhancement Type: Enhancement

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 5, 2022 •
edited
Loading

For consistency with rpcBlockchainInfoFunc in line 80 above (and thus readability), I would:

  • use int64
  • rename beginBlock and endBlock to minHeight and maxHeight

Originally posted by @sergio-mena in #898 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blobstream quantum gravity bridge T:enhancement Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: int64 for data commitment block heights rootulp/celestia-core
2 participants
@rootulp @rach-id