From dd18169ec8a0fa088df39998ed47149500197c23 Mon Sep 17 00:00:00 2001
From: Viacheslav <viacheslavgonkivskyi@gmail.com>
Date: Tue, 23 Jan 2024 13:01:56 +0200
Subject: [PATCH] feat(blob/service): cover getByCommitment with benchmark
 (#3116)

Added the benchmark for `getByCommitment`

`BenchmarkGetByCommitment-12 3139 380827 ns/op 701647 B/op 4990
allocs/op`


[profile.pdf](https://github.com/celestiaorg/celestia-node/files/13987571/profile.pdf)
---
 blob/service_test.go         | 23 ++++++++++++++++++++++-
 header/headertest/testing.go |  2 +-
 2 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/blob/service_test.go b/blob/service_test.go
index 6777084eb4..3e22f887af 100644
--- a/blob/service_test.go
+++ b/blob/service_test.go
@@ -414,7 +414,28 @@ func TestService_GetAllWithoutPadding(t *testing.T) {
 	require.NoError(t, err)
 }
 
-func createService(ctx context.Context, t *testing.T, blobs []*Blob) *Service {
+// BenchmarkGetByCommitment-12    	    3139	    380827 ns/op	  701647 B/op	    4990 allocs/op
+func BenchmarkGetByCommitment(b *testing.B) {
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
+	b.Cleanup(cancel)
+	appBlobs, err := blobtest.GenerateV0Blobs([]int{32, 32}, true)
+	require.NoError(b, err)
+
+	blobs, err := convertBlobs(appBlobs...)
+	require.NoError(b, err)
+
+	service := createService(ctx, b, blobs)
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		b.ReportAllocs()
+		_, _, err = service.getByCommitment(
+			ctx, 1, blobs[1].Namespace(), blobs[1].Commitment,
+		)
+		require.NoError(b, err)
+	}
+}
+
+func createService(ctx context.Context, t testing.TB, blobs []*Blob) *Service {
 	bs := ipld.NewMemBlockservice()
 	batching := ds_sync.MutexWrap(ds.NewMapDatastore())
 	headerStore, err := store.NewStore[*header.ExtendedHeader](batching)
diff --git a/header/headertest/testing.go b/header/headertest/testing.go
index 9907fd7eb4..e97f7f7825 100644
--- a/header/headertest/testing.go
+++ b/header/headertest/testing.go
@@ -297,7 +297,7 @@ func RandBlockID(testing.TB) types.BlockID {
 	return bid
 }
 
-func ExtendedHeaderFromEDS(t *testing.T, height uint64, eds *rsmt2d.ExtendedDataSquare) *header.ExtendedHeader {
+func ExtendedHeaderFromEDS(t testing.TB, height uint64, eds *rsmt2d.ExtendedDataSquare) *header.ExtendedHeader {
 	valSet, vals := RandValidatorSet(10, 10)
 	gen := RandRawHeader(t)
 	dah, err := share.NewRoot(eds)