Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: move empty square tests to share/empty_test.go #2266

Open
Wondertan opened this issue May 29, 2023 · 3 comments
Open

core: move empty square tests to share/empty_test.go #2266

Wondertan opened this issue May 29, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Wondertan
Copy link
Member

We should move these empty square tests to share/empty_test.go, as this is where empty square logic is located.

Originally posted by @Wondertan in #2253 (comment)
@Wondertan Wondertan added the good first issue Good for newcomers label May 29, 2023
@Wondertan Wondertan mentioned this issue May 29, 2023
Merged
5 tasks
@Chirag018
Copy link
Contributor

Hey, @Wondertan would like to work on this

@Wondertan
Copy link
Member Author

Hey @Chirag018. Thanks for showing your interest.

This task is pretty basic, and if you want something more fun and valuable take a look at #2278

@Chirag018
Copy link
Contributor

Thanks for the advice:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wondertan @Chirag018