Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): building simapp docker image #47

Merged
merged 8 commits into from
Dec 18, 2024
Merged

fix(docker): building simapp docker image #47

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7439c24
docs: improve README and Makefile
rootulp Dec 17, 2024
2d59189
more cleanup
rootulp Dec 17, 2024
89c2828
fix: comments
rootulp Dec 17, 2024
864d3a5
fix: simd issue
rootulp Dec 17, 2024
51abae0
revert: unnecessary change
rootulp Dec 17, 2024
6960701
Merge branch 'rp/cleanup' into rp/fix-simd-exec
rootulp Dec 17, 2024
6aed3fe
fix: build docker image before installing dependencies
rootulp Dec 17, 2024
7f769d3
Update Makefile
rootulp Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Stage 1: generate txsim binary
# Stage 1: Generate the simapp binary (simd)
FROM --platform=$BUILDPLATFORM docker.io/golang:1.23.1-alpine3.20 as builder

ARG TARGETOS
Expand All @@ -19,7 +19,7 @@ WORKDIR /celestia_zkevm_ibc_demo

RUN uname -a &&\
CGO_ENABLED=${CGO_ENABLED} GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
make build
make build-simapp

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the fix. make build doesn't do anything b/c it was recently renamed to make build-simapp

# Stage 2: create a minimal image with the binary
FROM docker.io/alpine:3.20
Expand Down
2 changes: 1 addition & 1 deletion testing/files/simapp-validator/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Copy config files from testing/files/celestia-validator to .tmp directory
cp -r /testapp_files/* /home/celestia/

exec /bin/simd start --home /home/celestia
exec /bin/simd start --home /home/celestia
Loading