Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to publishing Go modules from this repo #20

Closed
rootulp opened this issue Jan 17, 2024 · 1 comment
Closed

Path to publishing Go modules from this repo #20

rootulp opened this issue Jan 17, 2024 · 1 comment
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 17, 2024

Problem

We're currently maintaining two copies of this code. One in this repo and one in https://github.com/celestiaorg/celestia-app

Proposal

Ideally we only maintain one copy of this code. A path to maintaining one copy of the code is:

  1. Publish Go modules from this repo. Optionally consider cutting a 1.0.0 release of this repo.
  2. Modify celestia-app to delete the duplicate code and instead depend on modules published by this repo.

We should probably enumerate a list of issues that need to be resolved prior to publishing these Go modules.

@rootulp
Copy link
Collaborator Author

rootulp commented Jan 23, 2024

@cmwaters already cut https://github.com/celestiaorg/go-square/releases/tag/v1.0.0-rc0 and is working on using it in celestia-app. See celestiaorg/celestia-app#3026

so it seems like we don't need to enumerate a list of issues.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants