Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(makefile): add lint, test, & benchmark commands. #29

Merged
merged 5 commits into from
Jan 30, 2024
Merged

chore(makefile): add lint, test, & benchmark commands. #29

merged 5 commits into from
Jan 30, 2024

Conversation

00x-dx
Copy link
Contributor

@00x-dx 00x-dx commented Jan 24, 2024

Update Makefile with lint, test and benchmark commands.

@00x-dx 00x-dx requested review from a team as code owners January 24, 2024 13:31
@00x-dx 00x-dx requested review from rootulp, rach-id, walldiss and renaynay and removed request for a team January 24, 2024 13:31
@celestia-bot celestia-bot requested review from a team January 24, 2024 13:32
rootulp
rootulp previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution! We may consider also adding: make help. See here but that could be a follow-up PR.

Makefile Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team January 25, 2024 06:07
rootulp
rootulp reviewed Jan 25, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team January 25, 2024 17:51
@rootulp rootulp merged commit be1a47d into celestiaorg:main Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@rach-id rach-id Awaiting requested review from rach-id rach-id is a code owner automatically assigned from celestiaorg/celestia-core

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner automatically assigned from celestiaorg/celestia-node

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner automatically assigned from celestiaorg/celestia-node

Assignees

@00x-dx 00x-dx

Labels
external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@00x-dx @rootulp @distractedm1nd