-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve public API #57
Conversation
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 76.70% 76.45% -0.25%
==========================================
Files 9 9
Lines 382 378 -4
==========================================
- Hits 293 289 -4
Misses 57 57
Partials 32 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think we can merge this as is. Though we should open an issue to make sure we test all public APIs (including methods introduced here) and about test coverage.
Partially addresses #12.
Don't export
dataSquare
methods, and instead only exportExtendedDataSquare
methods that wrap those. Functionally mostly the same, exceptRow
andCol
now return copies, so the caller can't accidentally write to internal slices in a bad way.