-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
13 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
### store.Put safety | ||
|
||
This repo demonstrates a safety issue with store.Put that might be causing | ||
block corruption. | ||
|
||
branch names correspond to celestia node versions. | ||
|
||
# TODO | ||
* report issue | ||
* create issue for defer f.close | ||
- we should not ignore error from f.close: https://www.joeshaw.org/dont-defer-close-on-writable-files/ | ||
* create issue for fsync | ||
- we should fsync before close so that sync errs are not ignored: https://michael.stapelberg.ch/posts/2017-01-28-golang_atomically_writing/ |