Skip to content

Commit

Permalink
readme
Browse files Browse the repository at this point in the history
  • Loading branch information
tuxcanfly committed Aug 23, 2023
1 parent fd53c65 commit 6923329
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
### store.Put safety

This repo demonstrates a safety issue with store.Put that might be causing
block corruption.

branch names correspond to celestia node versions.

# TODO
* report issue
* create issue for defer f.close
- we should not ignore error from f.close: https://www.joeshaw.org/dont-defer-close-on-writable-files/
* create issue for fsync
- we should fsync before close so that sync errs are not ignored: https://michael.stapelberg.ch/posts/2017-01-28-golang_atomically_writing/

0 comments on commit 6923329

Please sign in to comment.