From 6923329e570d8996f6761e0221e5e0745e417153 Mon Sep 17 00:00:00 2001 From: Javed Khan Date: Wed, 23 Aug 2023 07:53:03 -0700 Subject: [PATCH] readme --- README.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 README.md diff --git a/README.md b/README.md new file mode 100644 index 0000000..6b5a83f --- /dev/null +++ b/README.md @@ -0,0 +1,13 @@ +### store.Put safety + +This repo demonstrates a safety issue with store.Put that might be causing +block corruption. + +branch names correspond to celestia node versions. + +# TODO +* report issue +* create issue for defer f.close + - we should not ignore error from f.close: https://www.joeshaw.org/dont-defer-close-on-writable-files/ +* create issue for fsync + - we should fsync before close so that sync errs are not ignored: https://michael.stapelberg.ch/posts/2017-01-28-golang_atomically_writing/